Skip to content

Fixed grid layout #1094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 9, 2022
Merged

Fixed grid layout #1094

merged 1 commit into from
Jul 9, 2022

Conversation

AldinRekic
Copy link
Contributor

Margin of first and last grid item shift top and bottom row layout off-center.

@AldinRekic
Fixed grid layout
00a5821 
Margin of first and last grid item shift top and bottom row layout off-center.
@MatanBobi
Copy link
Member

Hi @AldinRekic!
Thanks for the contribution.
Can you please share a screenshot for the before and after your changes?

@AldinRekic
Copy link
Contributor Author

AldinRekic commented Jun 23, 2022 •
edited
Loading

Hey @MatanBobi! Here are the Screenshots!

Before:
beforeChange
After:
afterChange

Additional screenshots:
Before:
gridNoChange
After:
gridAfterChange

timdeschryver
timdeschryver approved these changes Jun 23, 2022
View reviewed changes
Copy link
Member

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You got a sharp eye! 👍

@alexkrolick
Copy link
Collaborator

Thanks - would it be possible to align the text baselines as well, while you're here? 🙏

@AldinRekic
Copy link
Contributor Author

@alexkrolick Svelte, React and React Native images are not 80x80 like the rest. Svelte width is under 80px but width doesn't cause vertical text shift. React and React Native (both are 80x73) images are causing the text baseline to shift. I would adjust all 3 images to have it nicely standardized (even though Svelte image doesn't cause any issues right now).

@timdeschryver
Copy link
Member

Going to merge this since it's already better than the current grid.
Feel free to create a follow up PR to align the baselines.

@timdeschryver timdeschryver merged commit ee2f427 into testing-library:main Jul 9, 2022
@timdeschryver
Copy link
Member

@all-contributors please add @AldinRekic for design

@allcontributors allcontributors bot mentioned this pull request Jul 9, 2022
Merged
@allcontributors
Copy link
Contributor

@timdeschryver

I've put up a pull request to add @AldinRekic! 🎉

@AldinRekic AldinRekic deleted the patch-2 branch February 29, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timdeschryver timdeschryver timdeschryver approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AldinRekic @MatanBobi @alexkrolick @timdeschryver