Skip to content

style: add missing file title prop to code blocks #1076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 2, 2022
Merged

style: add missing file title prop to code blocks #1076

merged 1 commit into from
Jun 2, 2022

Conversation

mrazauskas
Copy link
Contributor

This PR is an attempt to unify the style of file titles in the documentation. I noticed that several code blocks had comments with file titles instead of title prop.

Also I made few minor styling changes. Just could not leave these. Hope that’s fine.

Copy link
Member

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@timdeschryver timdeschryver merged commit 4285387 into testing-library:main Jun 2, 2022
@timdeschryver
Copy link
Member

@all-contributors please add @mrazauskas for docs

@allcontributors
Copy link
Contributor

@timdeschryver

I've put up a pull request to add @mrazauskas! 🎉

@mrazauskas mrazauskas deleted the style-file-titles branch June 2, 2022 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants