Skip to content

merge branch-align-render-options with next #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 14 commits into from
Closed

merge branch-align-render-options with next #331

wants to merge 14 commits into from

Conversation

yanick
Copy link
Collaborator

@yanick yanick commented Feb 28, 2024

#325, merged with next's HEAD

mcous and others added 14 commits February 15, 2024 13:52
@mcous
fix!: align target and baseElement options with testing-library
2ce3309 
Fixes #312, fixes #313

BREAKING CHANGES: The `container` option has been renamed to `baseElement`,
  `result.container` is now set to `target` rather than `baseElement`,
  and `render` will now throw if you mix props with the `target` option.
@mcous
fixup: simplify
450809d
@mcous
fixup: formatting
2c7f460
@mcous
fixup: formatting
9053515
@mcous
fixup: fix rerender types
f4ae93d
@mcous
fixup: replace some removed Svelte v5 APIs
3aa48e9
@yanick
Merge remote-tracking branch 'origin/next' into align-render-options
54f23db
@yanick
wip
9172cdf
@yanick
implement inheritance with classes
e10c11a
@yanick
support for svelte 5
1df1c7c
@yanick
Merge branch 'as-class' into align-render-options
926c269
@yanick
all tests pass
55e8355
@yanick
Merge remote-tracking branch 'origin/next' into align-render-options
e02a437
@yanick
add target to the options
ad06be3
@yanick yanick mentioned this pull request Feb 28, 2024
Merged
@mcous
Copy link
Collaborator

mcous commented Apr 22, 2024

Work from this branch was incorporated into #325

@mcous mcous closed this Apr 22, 2024
@mcous mcous deleted the align-render-options-merged branch June 2, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yanick @mcous