Skip to content

test: add simple typing tests #298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 1, 2024
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .eslintrc.cjs
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,13 @@ module.exports = {
'simple-import-sort/imports': 'error',
},
overrides: [
{
files: ['*.svelte'],
parser: 'svelte-eslint-parser',
parserOptions: {
parser: '@typescript-eslint/parser',
},
},
{
files: ['*.ts'],
parser: '@typescript-eslint/parser',
Expand Down
10 changes: 8 additions & 2 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,14 @@ jobs:
npm install --no-package-lock
npm install --no-save svelte@${{ matrix.svelte }}

- name: ▶️ Run validate script
run: npm run validate
- name: ▶️ Test
run: npm test

- name: ▶️ Lint and type-check
if: ${{ matrix.node == '20' && matrix.svelte == '4' }}
run: |
npm run lint
npm run types

- name: ⬆️ Upload coverage report
uses: codecov/codecov-action@v3
Expand Down
5 changes: 4 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,9 @@
"test": "vitest run --coverage",
"test:watch": "vitest",
"test:update": "vitest run --update",
"types": "svelte-check",
"setup": "npm install && npm run validate",
"validate": "npm-run-all test",
"validate": "npm-run-all test types",
"contributors:add": "all-contributors add",
"contributors:generate": "all-contributors generate"
},
Expand Down Expand Up @@ -84,11 +85,13 @@
"eslint-plugin-simple-import-sort": "10.0.0",
"eslint-plugin-svelte": "2.35.1",
"eslint-plugin-vitest-globals": "1.4.0",
"expect-type": "^0.17.3",
"jsdom": "^22.1.0",
"npm-run-all": "^4.1.5",
"prettier": "3.2.4",
"prettier-plugin-svelte": "3.1.2",
"svelte": "^3 || ^4",
"svelte-check": "^3.6.3",
"svelte-jester": "^3.0.0",
"typescript": "^5.3.3",
"vite": "^4.3.9",
Expand Down
5 changes: 5 additions & 0 deletions src/__tests__/fixtures/Simple.svelte
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
<script lang="ts">
export let name: string
</script>

<h1>hello {name}</h1>
10 changes: 10 additions & 0 deletions tsconfig.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"compilerOptions": {
"module": "node16",
"noEmit": true,
"skipLibCheck": true,
"strict": true,
"types": ["svelte", "vite/client", "vitest", "vitest/globals"],
},
"include": ["src", "types"],
}
58 changes: 58 additions & 0 deletions types/types.test-d.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,58 @@
import { expectTypeOf } from 'expect-type'
import type { ComponentProps, SvelteComponent } from 'svelte'
import { describe, test } from 'vitest'

import Simple from '../src/__tests__/fixtures/Simple.svelte'
import * as subject from './index.js'

describe('types', () => {
test('render is a function that accepts a Svelte component', () => {
subject.render(Simple, { name: 'Alice' })
subject.render(Simple, { props: { name: 'Alice' } })
})

test('invalid prop types are rejected', () => {
// @ts-expect-error: name should be a string
subject.render(Simple, { name: 42 })

// @ts-expect-error: name should be a string
subject.render(Simple, { props: { name: 42 } })
})

test('render result has container and component', () => {
const result = subject.render(Simple, { name: 'Alice' })

expectTypeOf(result).toMatchTypeOf<{
container: HTMLElement
component: SvelteComponent<{ name: string }>
debug: (el?: HTMLElement) => void
rerender: (options: ComponentProps<Simple>) => void
unmount: () => void
}>()
})

test('render result has default queries', () => {
const result = subject.render(Simple, { name: 'Alice' })

expectTypeOf(result.getByRole).parameters.toMatchTypeOf<
[role: subject.ByRoleMatcher, options?: subject.ByRoleOptions]
>()
})

test('render result can have custom queries', () => {
const [getByVibes] = subject.buildQueries(
(_container: HTMLElement, vibes: string) => {
throw new Error(`unimplemented ${vibes}`)
},
() => '',
() => ''
)
const result = subject.render(
Simple,
{ name: 'Alice' },
{ queries: { getByVibes } }
)

expectTypeOf(result.getByVibes).parameters.toMatchTypeOf<[vibes: string]>()
})
})