Skip to content

fix: added module path for types to the exports map #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 25, 2023

Conversation

AdrianGonz97
Copy link
Contributor

The exports map in package.json was missing it's types module path, causing the import of @testing-library/svelte to throw a type error whenever users had "moduleResolution": "nodenext" set in their tsconfig.json.

@AdrianGonz97 AdrianGonz97 changed the title Fixed the exports map fix: added module path for types to the exports map Jun 25, 2023
@AdrianGonz97
Copy link
Contributor Author

Additionally, I'm pretty sure this import path: https://github.com/testing-library/svelte-testing-library/blob/a7ad7fd969f2dc0d0cc70bb81539991a8c77f327/types/index.d.ts#L6-L6C71 should be 'svelte' rather than 'svelte/types/runtime'. I mention this because this is no longer a valid path in Svelte 4. Importing directly from the 'svelte' path is supported in both version.

I can add it to this PR if that's alright.

@yanick
Copy link
Collaborator

yanick commented Jun 25, 2023 via email

@AdrianGonz97
Copy link
Contributor Author

@yanick Done 👍

@yanick yanick merged commit 5307a37 into testing-library:main Jun 25, 2023
@yanick
Copy link
Collaborator

yanick commented Jun 25, 2023

Merged, thanks!

@pngwn
Copy link

pngwn commented Jun 26, 2023

How frequently do you cut releases? My CI is currently failing because of a malformed exports map (no ./ at the start), would be good to get this out as soon as possible.

@yanick
Copy link
Collaborator

yanick commented Jun 26, 2023

I just need to have a pr with the right keyword. Will try to do that later on today if i can

@github-actions
Copy link

🎉 This PR is included in version 4.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants