Skip to content

fix: update incorrect Node version requirement from 8 to 10 #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 31, 2022

Conversation

nickserv
Copy link
Member

@nickserv nickserv commented Sep 21, 2021

Also tests on Node 14 and 16. IMO this isn't a breaking change, since Node 8 was already broken because of our DOM Testing Library version using newer syntax.

@nickserv nickserv force-pushed the add-node-engine-versions-to-ci branch from 60f6a18 to 6843e26 Compare September 21, 2021 14:26
@nickserv nickserv changed the title chore: add Node engine versions to CI fix: update incorrect Node version requirement from 8 to 10 Sep 21, 2021
@nickserv nickserv marked this pull request as ready for review September 21, 2021 14:40
@nickserv nickserv requested a review from mihar-22 September 21, 2021 14:45
@yanick yanick self-requested a review April 7, 2022 21:37
@yanick yanick force-pushed the add-node-engine-versions-to-ci branch from d922b4b to 129cc98 Compare May 31, 2022 13:28
@yanick yanick merged commit 5336903 into main May 31, 2022
@github-actions
Copy link

🎉 This PR is included in version 3.1.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@nickserv nickserv deleted the add-node-engine-versions-to-ci branch August 28, 2022 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants