Skip to content

chore(dev-deps): upgrade to svelte-jester 2.0 #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Sep 21, 2021

Conversation

benmccann
Copy link
Contributor

@benmccann benmccann commented Aug 4, 2021

svelte-jester 2 is a big improvement because it no longer needs to start new node processes thanks to async transformers being added in Jest 27

@benmccann benmccann changed the title Upgrade to svelte-jester 2.0 chore(dev-deps): upgrade to svelte-jester 2.0 Aug 4, 2021
@benmccann
Copy link
Contributor Author

@nickmccurdy @MirrorBytes @mihar-22 do you think we could merge this? Thanks!

@mihar-22
Copy link
Collaborator

LGTM! Need to pull branch and test but I haven't been up to date with svelte-testing-library in a while so probably best to defer to @nickmccurdy.

@nickserv
Copy link
Member

nickserv commented Sep 20, 2021

Hi, sorry for the delay. The svelte-jester update sounds good to me though I'm not experienced with Svelte.

I ran the tests locally and they failed with the same issues that I fixed in #161 (Jest 27 no longer loads JSDOM by default). I added those fixes to this branch and the tests are now passing locally. I also cleaned up the test code, I don't think DOM cleanup is necessary since Jest creates new environments between test runs anyway.

Please review when you have a chance.

@nickserv
Copy link
Member

I got CI working here, but unfortunately it seems like svelte-jester 2 requires Node 14, and Node 12 is still officially supported until April. This package still supports all the way back to Node 8 though. How should we handle this?

@benmccann
Copy link
Contributor Author

Ok, I sent a PR to fix that: svelteness/svelte-jester#83

@benmccann
Copy link
Contributor Author

@nickmccurdy I've updated this PR to svelte-jester 2.1.4, which supports older versions of Node

@nickserv
Copy link
Member

Thanks for the fix! Looks great, we seem to have cut test times in half.

@nickserv nickserv merged commit 009fb6c into testing-library:main Sep 21, 2021
@nickserv
Copy link
Member

@all-contributors add @benmccann for tests

@allcontributors
Copy link
Contributor

@nickmccurdy

I've put up a pull request to add @benmccann! 🎉

@testing-library testing-library deleted a comment from allcontributors bot Sep 21, 2021
@nickserv
Copy link
Member

@all-contributors add @mihar-22 for review

@allcontributors
Copy link
Contributor

@nickmccurdy

I've put up a pull request to add @mihar-22! 🎉

@github-actions
Copy link

🎉 This PR is included in version 3.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants