Skip to content

chore: update all deps #842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 4, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"setup": "npm install && npm run validate -s",
"test": "kcd-scripts test",
"test:update": "npm test -- --updateSnapshot --coverage",
"typecheck": "dtslint ./types/",
"typecheck": "kcd-scripts typecheck --build types",
"validate": "kcd-scripts validate"
},
"files": [
Expand Down Expand Up @@ -48,15 +48,14 @@
},
"devDependencies": {
"@testing-library/jest-dom": "^5.11.6",
"@types/react-dom": "^16.9.9",
"@types/react-dom": "^17.0.0",
"dotenv-cli": "^4.0.0",
"dtslint": "4.0.5",
"kcd-scripts": "^7.0.3",
"kcd-scripts": "^7.5.1",
"npm-run-all": "^4.1.5",
"react": "^17.0.1",
"react-dom": "^17.0.1",
"rimraf": "^3.0.2",
"typescript": "^4.0.5"
"typescript": "^4.1.2"
},
"peerDependencies": {
"react": "*",
Expand Down
4 changes: 2 additions & 2 deletions src/__tests__/rerender.js
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,9 @@ test('hydrate will not update props until next render', () => {
hydrate: true,
})

expect(initialInputElement.value).toBe(firstValue)
expect(initialInputElement).toHaveValue(firstValue)

const secondValue = 'goodbye'
rerender(<input value={secondValue} onChange={() => null} />)
expect(initialInputElement.value).toBe(secondValue)
expect(initialInputElement).toHaveValue(secondValue)
})
4 changes: 2 additions & 2 deletions types/test.tsx
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import * as React from 'react'
import {render, fireEvent, screen, waitFor} from '@testing-library/react'
import * as pure from '@testing-library/react/pure'
import {render, fireEvent, screen, waitFor} from '.'
import * as pure from './pure'
Comment on lines -2 to +3
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't get the paths config set to make this work like it was before. I'm personally not that bothered by this, but if someone cares, feel free to update it :)


export async function testRender() {
const page = render(<div />)
Expand Down
20 changes: 2 additions & 18 deletions types/tsconfig.json
Original file line number Diff line number Diff line change
@@ -1,20 +1,4 @@
// this additional tsconfig is required by dtslint
// see: https://github.com/Microsoft/dtslint#typestsconfigjson
{
"compilerOptions": {
"module": "commonjs",
"lib": ["es6", "dom"],
"jsx": "react",
"noImplicitAny": true,
"noImplicitThis": true,
"strictNullChecks": true,
"strictFunctionTypes": true,
"noEmit": true,
"baseUrl": ".",
"skipLibCheck": true,
"paths": {
"@testing-library/react": ["."],
"@testing-library/react/pure": ["."]
}
}
"extends": "../node_modules/kcd-scripts/shared-tsconfig.json",
"include": ["."]
}
9 changes: 0 additions & 9 deletions types/tslint.json

This file was deleted.