Skip to content

chore: update React imports #811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 29, 2020
Merged

chore: update React imports #811

merged 1 commit into from
Oct 29, 2020

Conversation

MichaelDeBoey
Copy link
Member

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit de4352b:

Sandbox Source
React Configuration
kentcdodds/react-testing-library-examples Configuration

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I don't think this should make any substantive difference to consumers right?

@kentcdodds
Copy link
Member

Oh, also, thanks!

@eps1lon
Copy link
Member

eps1lon commented Oct 29, 2020

I don't think this should make any substantive difference to consumers right?

Might be better when bundled with webpack but slightly worse when transpiled to commonJS. Though ultimately negligible. If we see actual issues const React = require('react') is the best thing for modules not published as ES modules.

@MichaelDeBoey
Copy link
Member Author

This won't make any difference indeed.

@kentcdodds kentcdodds merged commit 0db8112 into testing-library:master Oct 29, 2020
@MichaelDeBoey MichaelDeBoey deleted the update-react-imports branch October 29, 2020 21:56
@testing-library-bot
Copy link

🎉 This PR is included in version 11.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants