fix: console.error doesn't have to be a string in act.compat.js #476
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
I'm happy to merge either of these once they pass the build and all the current tests :) |
|
actually found out that the Added a test for this, coverage should be 100% again |
|
@all-contributors please add @rvdkooy for code and tests |
|
I've put up a pull request to add @rvdkooy! 🎉 |
|
🎉 This PR is included in version 9.1.4 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
AEgan
added a commit
to AEgan/native-testing-library
that referenced
this pull request
Dec 12, 2019
prevents asyncAct throwing an error if the item being logged isn't a string. Coped mostly from testing-library/react-testing-library#476
4 tasks
bcarroll22
pushed a commit
to testing-library/native-testing-library
that referenced
this pull request
Dec 13, 2019
prevents asyncAct throwing an error if the item being logged isn't a string. Coped mostly from testing-library/react-testing-library#476
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
This PR fixes issue: #442 by adding type checking for args used in asyncAct function.
Why:
Current implementation assumes console.erorr was always called with a string even though it could be called with other types.
How:
Wrapped execution of code in a type check if statement to ensure operations are done only on string types.
Checklist: