Skip to content

incorrect referenced variable #474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 3, 2019
Merged

incorrect referenced variable #474

merged 1 commit into from
Sep 3, 2019

Conversation

aayushrajvanshi
Copy link
Contributor

@aayushrajvanshi aayushrajvanshi commented Sep 3, 2019 •
edited
Loading

What:

referenced incorrect state variable
state.success --> state.resolved

Why:

Complex example is broken.

How:

Checklist:

  • Documentation added to the
    docs site
  • Tests
  • Typescript definitions updated
  • Ready to be merged

@aayushrajvanshi aayushrajvanshi changed the title Update README.md incorrect referenced variable Sep 3, 2019
kentcdodds
kentcdodds approved these changes Sep 3, 2019
View reviewed changes
Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kentcdodds kentcdodds merged commit 59e20f8 into testing-library:master Sep 3, 2019
@kentcdodds
Copy link
Member

@all-contributors please add @aayushrajvanshi for docs

@allcontributors allcontributors bot mentioned this pull request Sep 3, 2019
Merged
@allcontributors
Copy link
Contributor

@kentcdodds

I've put up a pull request to add @aayushrajvanshi! 🎉

@kentcdodds
Copy link
Member

🎉 This PR is included in version 9.1.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kentcdodds kentcdodds kentcdodds approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aayushrajvanshi @kentcdodds