tests: added i18next example #399
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viniciusavieira
changed the title
kentcdodds
requested changes
Jun 28, 2019
There was a problem hiding this comment.
I'd actually like to move all the examples from this repo to this one: https://codesandbox.io/s/github/kentcdodds/react-testing-library-examples
That way we can keep the deps in this project slimmed down to only those that are needed for the project.
Could you make this PR to that other repo?
|
Sure, no problem.
|
|
Sorry, have the wrong link. That's correct 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Adding i18Next example with locale
Why: #390
How: I've put the logic to display to users how make test with locale in using i18next, I've create an example with a test.
Refs:
https://react.i18next.com/misc/testing
https://codesandbox.io/s/testing-library-i18next-vot1o
Checklist:
docs site
Once this PR is accepted I'll updated the docs site.