Skip to content

remove duplication of act #304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

mohamedmagdy17593
Copy link
Contributor

I have watched your youtube video "Updating react-testing-library for React 16.8.0 (part 2)" and notice that it would be cool to use act only one time, So I take the chance to contribute 😁

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure 👍

@kentcdodds kentcdodds merged commit d413665 into testing-library:master Feb 17, 2019
@mohamedmagdy17593 mohamedmagdy17593 deleted the pr/act-duplication branch February 17, 2019 15:39
@kentcdodds
Copy link
Member

🎉 This PR is included in version 5.9.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants