Modifies testHook to return unmount function #290
Conversation
| @@ -6,53 +6,76 @@ | |||
| */ | |||
There was a problem hiding this comment.
I'm guessing you had to skip the pre-commit hook or something. This should have auto-formatted when you commit it. Could you run npx kcd-scripts format please?
There was a problem hiding this comment.
I ran it and it added a linebreak in ISSUE_TEMPLATE.md and mock.react-transition-group.js. Should I also add it to the commit?
src/index.js
Outdated
| @@ -67,7 +67,8 @@ function TestHook({callback}) { | |||
| } | |||
|
|
|||
| function testHook(callback) { | |||
| render(<TestHook callback={callback} />) | |||
| const { unmount } = render(<TestHook callback={callback} />) | |||
There was a problem hiding this comment.
Let's also return rerender as well I think.
|
🎉 This PR is included in version 5.6.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
Would be nice to update typescript definition when changing API. 🙊 |
|
I haven't mess with TS typing for a long time now. Can you check if this is correct? |
|
Looks correct to me. |
|
Should I also add some guidance inside CONTRIBUTING.md?
I thought about adding a new section in "Commiting and Pushing changes" |
|
Sure 👍 |
|
wow, mind absolutely blown I love this library |
This PR solves #289, in which I asked to have a way to test the
useEffectcallback.What:
Adds a way to test hooks behavior when component unmounts.
Why:
To test
useEffectcallbacks, which are called when component unmounts.How:
Modifies
testHookto return an object with an exposedunmountfunction in it.As said in the issue #289, I didn't expose anything else to avoid encouraging unfocused tests. In the future, if someone asks for them, they could be included.
Checklist:
I also modified the file
examples/react-hookssouseCounteris not a default export, and addeduseDocumentTitleas example.I am not confident about the
useDocumentTitlethough, as its implementation is quirky and not a good example (ironically). But I couldn't think of another simple use ofuseEffectand its callback.