Skip to content

Add explicit any[] annotation to Query definition #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 4, 2019

Conversation

joeporpeglia
Copy link
Contributor

What: Bug

Why: The existing typescript definitions fail to compile with --noImplicitAny enabled.

How: I forked the project and tested that the updated declaration compiles correctly.

Checklist:

  • Documentation N/A
  • Tests N/A
  • Ready to be merged
  • Added myself to contributors table

@joeporpeglia joeporpeglia mentioned this pull request Jan 4, 2019
4 tasks
Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kentcdodds kentcdodds merged commit 14b567f into testing-library:master Jan 4, 2019
@joeporpeglia joeporpeglia deleted the patch-1 branch January 4, 2019 19:01
@joeporpeglia
Copy link
Contributor Author

And thank you for such a fast turnaround!

@kentcdodds
Copy link
Member

🎉 This PR is included in version 5.4.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

lucbpz pushed a commit to lucbpz/react-testing-library that referenced this pull request Jul 26, 2020
* docs: update README.md

* docs: update .all-contributorsrc

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants