New: expose option to override bound queries #177
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dom-testing-library will default the queries for us: https://github.com/kentcdodds/dom-testing-library/blob/cbbda90762f9b5c97471841b0d00f05ddfe772ba/src/get-queries-for-element.js#L12
kentcdodds
approved these changes
Sep 18, 2018
|
Do you think we should document this? I'm on the fence. |
|
🎉 This PR is included in version 5.1.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
I'll make a PR to document after using it more - might be part of a larger effort to show how to use custom queries |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Useful if you want to add or change the queries
Why:
The custom render method documented in the README works well for wrapping the rendered node, but needs an extension point for adding/overriding queries. For example this would let you override the getByTestId query with a query for a different data-attribute (common request).
How:
getQueriesForElement already takes a query argument, this exposes it in the render options argument
Checklist: