Pr/wait section add query by text #172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 This PR is included in version 5.1.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
julienw
pushed a commit
to julienw/react-testing-library
that referenced
this pull request
Dec 20, 2018
…ng-library#172) * feat(custom normalizer): allow custom control of normalization Adds an optional {normalizer} option to query functions; this is a transformation function run over candidate match text after it has had `trim` or `collapseWhitespace` run on it, but before any matching text/function/regexp is tested against it. The use case is for tidying up DOM text (which may contain, for instance, invisible Unicode control characters) before running matching logic, keeping the matching logic and normalization logic separate. * Expand acronyms out * Add `getDefaultNormalizer()` and move existing options This commit moves the implementation of `trim` + `collapseWhitespace`, making them just another normalizer. It also exposes a `getDefaultNormalizer()` function which provides the default normalization and allows for the configuration of it. Removed `matches` and `fuzzyMatches` from being publicly exposed. Updated tests, added new documentation for normalizer and getDefaultNormalizer, and removed documentation for the previous top-level `trim` and `collapseWhitespace` options. * Apply normalizer treatment to queryAllByDisplayValue
lucbpz
pushed a commit
to lucbpz/react-testing-library
that referenced
this pull request
Jul 26, 2020
Closes testing-library#306 Closes testing-library#301 Closes testing-library#235 Closes testing-library#181 Closes testing-library#172 Closes testing-library#31
lucbpz
pushed a commit
to lucbpz/react-testing-library
that referenced
this pull request
Jul 26, 2020
…ary#308) Closes testing-library#306 Closes testing-library#301 Closes testing-library#235 Closes testing-library#181 Closes testing-library#172 Closes testing-library#31
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
"Wait" section was missing
queryByTextdestructuring assignment, example doesn't work without it.https://github.com/kentcdodds/react-testing-library#wait
Why:
added the missing queryByText assignment.
How:
Edited the README.md manually and run
npm run add-contributorto update contributors file (following https://github.com/kentcdodds/react-testing-library/blob/master/CONTRIBUTING.md)Checklist: