-
Notifications
You must be signed in to change notification settings - Fork 1.1k
chore: Run release from 12.x branch #1044
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -58,8 +60,7 @@ jobs: | |||
runs-on: ubuntu-latest | |||
if: | |||
${{ github.repository == 'testing-library/react-testing-library' && | |||
contains('refs/heads/main,refs/heads/beta,refs/heads/next,refs/heads/alpha', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got introduced in testing-library/dom-testing-library#809 but at that point we didn't have a a filter in on.push.branches
so this seems redundant now.
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit c9943a0:
|
Codecov Report
@@ Coverage Diff @@
## 12.x #1044 +/- ##
========================================
Coverage ? 100.00%
========================================
Files ? 4
Lines ? 142
Branches ? 28
========================================
Hits ? 142
Misses ? 0
Partials ? 0 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. I wondered about this 😅 Thanks!
Should probably cherry-pick this into |
🎉 This PR is included in version 12.1.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Recent 12.x merge did not run GitHub actions.
I'm not following the current pattern for release branches so I just simplified it following the Filter pattern cheat sheet.
Comfirmed to work in https://github.com/eps1lon/react-testing-library/actions/runs/2150862258
dom-testing-library has the same pattern and we probably need to port that fix over there to prevent it spreading.