Skip to content

test(types): Don't assume implicit children #1042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 11, 2022

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Apr 11, 2022

Implicit children got removed in React 18 types (DefinitelyTyped/DefinitelyTyped#56210)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 11, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 7859096:

Sandbox Source
React Configuration
react-testing-library-examples Configuration

@codecov
Copy link

codecov bot commented Apr 11, 2022

Codecov Report

Merging #1042 (7859096) into main (ccd8a0d) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main     #1042   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          169       169           
  Branches        35        33    -2     
=========================================
  Hits           169       169           
Flag Coverage Δ
experimental 100.00% <ø> (ø)
latest 100.00% <ø> (ø)
next 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ccd8a0d...7859096. Read the comment docs.

@eps1lon eps1lon merged commit 93bc2c8 into testing-library:main Apr 11, 2022
@eps1lon eps1lon deleted the test/fix-react-18-types branch April 11, 2022 17:59
@github-actions
Copy link

🎉 This PR is included in version 13.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant