-
Notifications
You must be signed in to change notification settings - Fork 1.1k
createEvent is not being exported #373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I would have expected this line to export it: https://github.com/testing-library/dom-testing-library/blob/master/src/index.js#L12 |
Did you update the dom testing dependency with |
Edit: nvm RTL uses ^ not ~ for the DTL dependency. Ah, we’ll have to bump the version of DTL used and minor bump this library also. The line you referenced should cover it then since this re-exports everything. Wanna make a PR here as well? |
The example I posted is a fresh install from npm |
Any update on this ? |
I can’t reproduce this on a fresh install of RTL. Maybe try deleting package-lock or yarn.lock and node_modules and try a fresh install? The lockfile should say DTL is version 4.1.0 after an install of RTL ^7.0.0. |
That is why the patch is needed I tried last friday installing the newer query lib did not work maybe I did something wrong
…On 19 May 2019, 17:25 +0200, Brandon Carroll ***@***.***>, wrote:
I can’t reproduce this on a fresh install of RTL. Maybe try deleting package-lock or yarn.lock and node_modules and try a fresh install? The lockfile should say DTL is version 4.1.0 after an install of RTL ^7.0.0.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.
|
🎉 This issue has been resolved in version 7.0.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
@kentcdodds Thanks ;) |
react-testing-library
version: 7.0.0react
version: 16.8.6Relevant code or config:
https://codesandbox.io/s/reacttestinglibrary-createevent-gr9ms (click on the tests tab)
Problem description:
createEvent
is not being exportedThe text was updated successfully, but these errors were encountered: