Skip to content

[types] RenderResult.container of type HTMLElement #265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SavePointSam opened this issue Jan 14, 2019 · 1 comment
Closed

[types] RenderResult.container of type HTMLElement #265

SavePointSam opened this issue Jan 14, 2019 · 1 comment

Comments

@SavePointSam
Copy link
Contributor

The current typing of RenderResult.container leads to an error when trying to use container.firstChild.

Not all HTMLElements have a firstChild property. Since we know container should always be a <div />, it should be HTMLDivElement.

@SavePointSam
Copy link
Contributor Author

SavePointSam commented Jan 21, 2019

needed to add dom libs to my tsconfig.

{
  "compilerOptions": {
+    "lib": ["dom"],
  },
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant