Skip to content

docs: extra arguments #723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 24, 2021
Merged

docs: extra arguments #723

merged 1 commit into from
Oct 24, 2021

Conversation

Laishuxin
Copy link
Contributor

@Laishuxin Laishuxin commented Oct 24, 2021

What:

When I run the case above in TypeScript, I get an error "Expected 0 arguments, but got 1.ts(2554)". I just remove the extra arguments.

Why:

To improve the documents. these changes are necessary.

How:

Checklist:

  • Documentation updated
  • Added myself to contributors table

@netlify
Copy link

netlify bot commented Oct 24, 2021

✔️ Deploy Preview for react-hooks-testing-library ready!

🔨 Explore the source changes: c6f47c1

🔍 Inspect the deploy log: https://app.netlify.com/sites/react-hooks-testing-library/deploys/6174d4388814a20008ff7b79

😎 Browse the preview: https://deploy-preview-723--react-hooks-testing-library.netlify.app

@codecov
Copy link

codecov bot commented Oct 24, 2021

Codecov Report

Merging #723 (c6f47c1) into main (f42a2d5) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #723   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           15        15           
  Lines          246       246           
  Branches        34        34           
=========================================
  Hits           246       246           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f42a2d5...c6f47c1. Read the comment docs.

@mpeyper
Copy link
Member

mpeyper commented Oct 24, 2021

Thanks.

@mpeyper mpeyper merged commit 16d0119 into testing-library:main Oct 24, 2021
@mpeyper
Copy link
Member

mpeyper commented Oct 24, 2021

@all-contributors please add @Laishuxin for doc 😄

@allcontributors
Copy link
Contributor

@mpeyper

I've put up a pull request to add @Laishuxin! 🎉

@github-actions
Copy link

🎉 This PR is included in version 8.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants