refactor: move tests to specificly related folders

[joshuaellis]

What:

Proposal to move test files to be closer to the code that we're testing, and rename those test files to be *.test.ts(x).

Why:

This was discussed in #510, I'd say the main issue is they're all named the same and incredibly close together, now we're maintaining "three engines" we may mind that the testing needs to diverge, an example is seen in src/server where we need to test the hydration warnings. It also, imo, makes the repo look tidier.

Renaming the tests was a personal choice, if i'm jumping around a lot of files, it's really helpful to understand whats a test file just from the name. Added bonus, you normally get a different icon in your IDE.

Also we do want to try and figure out how to cover src/pure.ts so this wouldn't actually fit into the old test folder pattern because they were related to the renderer. Therefore when we cross that bridge I would suggest putting the test in src/__tests__ and thus naming it pure.test.ts.

Checklist:

• Tests
• Ready to be merged
  

[joshuaellis]

hm. probably need to move that tsconfig.json out of src/__tests__ and just into test.... that's annoying.

[mpeyper]

A few suggestions, but no showstoppers

[mpeyper]

You have forgotten to update the eslintrc file which is why the CI is failing.

[mpeyper]

hm. probably need to move that tsconfig.json out of src/__tests__ and just into test.... that's annoying.

If my other comments are right, you can just delete it

[codecov]

Codecov Report

Merging #531 (2957443) into beta (ca32bce) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              beta      #531   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           12        12           
  Lines          189       189           
  Branches        27        27           
=========================================
  Hits           189       189           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca32bce...2957443. Read the comment docs.

[joshuaellis]

Thanks for doing those updates.

[github-actions]

🎉 This PR is included in version 5.0.0-beta.8 🎉

The release is available on:

• npm package (@beta dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[github-actions]

🎉 This PR is included in version 5.0.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀