Skip to content

fix: ReactHooksRenderer renderHook was not expecting arguments #526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 7, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/core/index.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { CreateRenderer, Renderer, RenderResult, RenderHook } from '../types'
import { ResultContainer, RenderHookOptions } from '../types/internal'
import { CreateRenderer, Renderer, RenderResult, RenderHook, RenderHookOptions } from '../types'
import { ResultContainer } from '../types/internal'

import asyncUtils from './asyncUtils'
import { cleanup, addCleanup, removeCleanup } from './cleanup'
Expand Down
9 changes: 8 additions & 1 deletion src/types/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -48,13 +48,20 @@ export type RenderHook<
AsyncUtils

export interface ReactHooksRenderer {
renderHook: <TProps, TResult>() => RenderHook<TProps, TResult>
renderHook: <TProps, TResult, TOptions>(
callback: (props: TProps) => TResult,
options?: RenderHookOptions<TProps, TOptions>
) => RenderHook<TProps, TResult>
act: Act
cleanup: () => void
addCleanup: (callback: () => Promise<void> | void) => () => void
removeCleanup: (callback: () => Promise<void> | void) => void
}

export type RenderHookOptions<TProps, TOptions extends {}> = TOptions & {
initialProps?: TProps
}

export interface Act {
(callback: () => void | undefined): void
(callback: () => Promise<void | undefined>): Promise<undefined>
Expand Down
4 changes: 0 additions & 4 deletions src/types/internal.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,3 @@ export type ResultContainer<TValue> = {
setValue: (val: TValue) => void
setError: (error: Error) => void
}

export type RenderHookOptions<TProps, TOptions extends {}> = TOptions & {
initialProps?: TProps
}