Skip to content

Move to testing-library org and make scoped package #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kentcdodds opened this issue Jun 17, 2019 · 6 comments
Closed

Move to testing-library org and make scoped package #99

kentcdodds opened this issue Jun 17, 2019 · 6 comments

Comments

@kentcdodds
Copy link
Member

I could've sworn that this issue already existed, but I can't find it so here it is. I would like to formally invite you to bring this package into the testing-library org on GitHub and publish to the @testing-library scope under @testing-library/react-hooks.

I've sent you the invites etc. and you can learn more about the process of publishing to the scope here: testing-library/dom-testing-library#260 (comment)

Let me know if you have any questions or need assistance! Thanks!

@mpeyper
Copy link
Member

mpeyper commented Jun 17, 2019

Thanks. I'll hopefully get onto this tonight.

@mpeyper
Copy link
Member

mpeyper commented Jun 19, 2019

I'm mostly done on this. I've published @testing-library/[email protected] (closely followed by 1.0.1 and 1.0.2 😬) but I have not made any deprecated packages/warnings for react-hooks-testing-library, so I'll look at that next (another time).

The only thing is I seem to have lost some permissions (e.g. authorizings apps, viewing the settings, etc.) for this repo after transferring ownership. Not sure I've set the teams up right or not, or what the missing pieces of that puzzle are. perhaps you can double check them @kentcdodds?

@kentcdodds
Copy link
Member Author

Fixed that @mpeyper! Thanks!

@mpeyper
Copy link
Member

mpeyper commented Jun 19, 2019

@kentcdodds nothings appears to have changed on my end. Not sure what permissions I should have as part of an org, but I would have thought the "Settings" tab would still be visible? I don't have any major need to change any settings or authorise any apps or anything at the moment, and I've still got push access and able to publish, so I'm not really blocked by this, but I'd like those permissions back at some point if it's possible.

@kentcdodds
Copy link
Member Author

Sorry about that. It should be fixed now.

@mpeyper
Copy link
Member

mpeyper commented Jun 20, 2019

All good now 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants