Skip to content

Missing RenderHookResult type #536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
vbfox opened this issue Jan 12, 2021 · 2 comments
Closed

Missing RenderHookResult type #536

vbfox opened this issue Jan 12, 2021 · 2 comments
Labels
bug Something isn't working released on @beta

Comments

@vbfox
Copy link

vbfox commented Jan 12, 2021

  • react-hooks-testing-library version: 4.0.0

Relevant code or config:

import { RenderHookResult } from '@testing-library/react-hooks';

What you did:

I Updated a TypeScript project that was using 3.x & that used RenderHookResult to 4.0.0

What happened:

The type doesn't exists anymore

Reproduction:

Any code importing the type should fail to compile

Problem description:

Same problem as #534 but on the result type instead of the option parameter.

Suggested solution:

Add the interface back to the new typescript-rewritten version
@vbfox vbfox added the bug Something isn't working label Jan 12, 2021
@joshuaellis
Copy link
Member

this is fixed & released in v5.0.0-beta.9. However, you are welcome to submit a PR fixing the export issue.

@joshuaellis
Copy link
Member

This is released in v5.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working released on @beta
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vbfox @joshuaellis