Skip to content

Missing type for RenderHookOptions #534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jonkoops opened this issue Jan 12, 2021 · 4 comments · Fixed by #535
Closed

Missing type for RenderHookOptions #534

jonkoops opened this issue Jan 12, 2021 · 4 comments · Fixed by #535
Labels

Comments

@jonkoops
Copy link
Contributor

  • react-hooks-testing-library version: 4.0.0

Relevant code or config:

import { RenderHookOptions } from '@testing-library/react-hooks'

What you did:

Import the RenderHookOptions type.

What happened:

The RenderHookOptions type was not found.

Reproduction:

See code.

Problem description:

Since the library has been re-written in TypeScript it no longer exports the RenderHookOptions as a seperate type. This is causing our CI to fail: Amsterdam/amsterdam-styled-components#1469

Suggested solution:

Restore the RenderHookOptions type so it can be used again.

@jonkoops jonkoops added the bug Something isn't working label Jan 12, 2021
@joshuaellis
Copy link
Member

This is solved in v5.0.0-beta.9 but it also does seem to be cropping up more and I appreciate some people don't want to use a beta library.

@github-actions
Copy link

🎉 This issue has been resolved in version 4.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@jonkoops
Copy link
Contributor Author

Thanks for the quick response @joshuaellis 👍

@github-actions
Copy link

🎉 This issue has been resolved in version 5.0.0-beta.11 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants