fix matches to account for empty strings

[mcgloneleviROOT]

What:

The specific issue I am trying to fix via this PR is here:

#86

Basically, the *DisplayValue queries do not work with empty strings. This fixes the matches file so that we can match empty strings.

Why:

I think these changes are necessary to match empty text fields.

How:

I verified that this fixed my issue locally. I ran tests after this, and they passed.

Checklist:

• Documentation added to the
  docs site N/A
• Typescript definitions updated N/A
• Tests (I ran them locally and they worked. I can add additional test cases if deemed necessary.)
• Ready to be merged

[codecov]

Codecov Report

Merging #87 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master    #87   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          20     20           
  Lines         268    268           
  Branches       67     67           
=====================================
  Hits          268    268

Impacted Files	Coverage Δ
src/lib/matches.js	100% <100%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 251c07d...2be7283. Read the comment docs.

[TAGraves]

This looks good to me. That conditional was added just for the case where textToMatch is a string. We could do some more sophisticated type checking here, but your solution seems sufficient.

[bcarroll22]

Awesome, thanks!

Looks like you’re already in the contributors table 💯

[bcarroll22]

🎉 This PR is included in version 5.0.2 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀