Skip to content

chore: enable eslint-plugin-prettier #922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

G-Rath
Copy link
Contributor

@G-Rath G-Rath commented Aug 4, 2024

Checks

Changes

  • enables eslint-plugin-prettier via it's recommended ruleset

Context

Extending prettier enables eslint-config-prettier which only disables ESLint rules that conflict with prettier - it's the eslint-plugin-prettier config that enables both the prettier/prettier rule and eslint-config-prettier.

Copy link

codecov bot commented Aug 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.31%. Comparing base (93a6ab9) to head (4c6f7c9).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #922      +/-   ##
==========================================
+ Coverage   96.23%   96.31%   +0.08%     
==========================================
  Files          44       44              
  Lines        2419     2445      +26     
  Branches     1000     1023      +23     
==========================================
+ Hits         2328     2355      +27     
+ Misses         91       90       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Belco90
Copy link
Member

Belco90 commented Aug 7, 2024

This was done on purpose. We don't want to run stylistic rules as part of ESLint.

@Belco90 Belco90 closed this Aug 7, 2024
@G-Rath G-Rath deleted the run-prettier-eslint branch August 8, 2024 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants