feat(no-debug): scan for screen.debug()
#73
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Belco90
requested changes
Jan 31, 2020
There was a problem hiding this comment.
Hi there! First of all thanks for your contribution 🎉
The update for the rule implementation and the tests seem fine. I'm gonna ask only for a couple of doc changes, could you add:
- screen.debug reference to "Further Reading" section
- an incorrect example using
screen.debugin "Rule Details" section
Thanks!
|
Hi @Belco90, It occurred to me that I forgot about docs while you where reviewing it 😅 Thanks for quick response, I've added incorrect code examples and links. |
Belco90
approved these changes
Feb 1, 2020
|
🎉 This PR is included in version 2.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
@all-contributors add @KubaJastrz for code, docs and test |
|
I've put up a pull request to add @KubaJastrz! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
screenexport was added in@testing-library/[email protected].I think
no-debugrule should also take into consideration thescreen.debug()as it's basically just an utility to console.log entire testing container.ref: testing-library/dom-testing-library#429