Skip to content

chore: fix new linting errors reported #723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 29, 2023
Merged

Conversation

Belco90
Copy link
Member

@Belco90 Belco90 commented Jan 29, 2023

Checks

Changes

  • Fix new linting errors reported by eslint-plugin-import

Context

Since we don't have our dependencies pinned, some ESLint plugin/config got updated and started reporting new errors in #722. I'm tired of this behavior, already happened many times. I'm pinning the dependencies in another PR and setting up Renovatebot.

@Belco90 Belco90 requested a review from a team January 29, 2023 13:02
@Belco90 Belco90 self-assigned this Jan 29, 2023
@Belco90 Belco90 added the chore Changes that affect the build system, CI config or other changes that don't modify src/test files label Jan 29, 2023
Copy link
Collaborator

@sjarva sjarva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! And also, short and easy PR to review 🚀

@sjarva
Copy link
Collaborator

sjarva commented Jan 29, 2023

Also, sounds good that we'll pin the dependencies and start using a bot to update them 🤖 📦

@Belco90 Belco90 merged commit e2c9bbb into main Jan 29, 2023
@Belco90 Belco90 deleted the fix_new_linting_errors branch January 29, 2023 13:26
@MichaelDeBoey
Copy link
Member

These errors are due to eslint-config-kentcdodds, so using an exact version for that would have fixed this as well @Belco90

@Belco90
Copy link
Member Author

Belco90 commented Jan 29, 2023

@MichaelDeBoey we got similar errors from many different libraries. Sorry but I'm tired of fixing errors out of nowhere.

@github-actions
Copy link

github-actions bot commented Feb 8, 2023

🎉 This PR is included in version 5.10.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

github-actions bot commented Aug 5, 2023

🎉 This PR is included in version 6.0.0-alpha.15 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Changes that affect the build system, CI config or other changes that don't modify src/test files released on @alpha released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants