test(no-node-access): add more valid test cases #684
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These examples were gotten from discussions in issue #386
Belco90
approved these changes
Oct 23, 2022
Belco90
changed the title
|
🎉 This PR is included in version 6.0.0-alpha.14 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 5.10.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These examples were gotten from discussions in issue #386
Checks
npm run generate:rules-list)npm run generate:configs)Changes
no-node-accessContext
Not closing an existing issue, just adding one test that should have been added in #658. I commented in that PR that it wouldn't be fixing an error from a code like this (component with destructured props), but turns out, that this code hasn't produced an error, it is totally valid from this rule's perspective.