-
Notifications
You must be signed in to change notification settings - Fork 148
style: indent lines with tabs instead of spaces #633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Not sure if we already need to do it before the Prettier discussion is resolved though. 🤔
I would personally wait for it & do it together with the Prettier v3 update.
Not sure what Prettier discussion you are referring to, but the original issue for v3 is still open. Since the first alpha for Prettier v3 was released a few days ago with no change related to using tabs, I'd just switch to tabs in our codebase. If they do the change in v3, we are ready for it. If not, we made our codebase more accessible, even if Prettier didn't change its defaults! |
@Belco90 I was indeed referring to the original issue that's still open.
I think that's the whole discussion, that it's not 100% sure it's more accessible. I think we should have waited to see what the outcome of the discussion is, especially since the only reason we're doing this change is because of something that's not 100% resolved/clear. |
🎉 This PR is included in version 5.6.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Checks
npm run generate:rules-list
)npm run generate:configs
)Changes
Context
There was no ticket for this. However, Prettier is considering switching to tabs by default in v3. This is a great change, you can find the motivation behind it here: prettier/prettier#7475
I think we should switch to tabs now to improve the accessibility of the code. The tab size can be customized in GitHub here: https://github.com/settings/appearance