Skip to content

docs(prefer-presence-queries): add a note to discourage usage of options #601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

zaicevas
Copy link
Contributor

@zaicevas zaicevas commented Jun 6, 2022

Checks

  • I have read the contributing guidelines.
  • If some rule is added/updated/removed, I've regenerated the rules list (npm run generate:rules-list)
  • If some rule meta info is changed, I've regenerated the plugin shared configs (npm run generate:configs)

Changes

  • Added a note in prefer-presence-queries that discourages the use of options

Context

In #557 2 prefer-presence-queries options were added due to false positives described in #518.

As I understand, these options are a short-term workaround. They will be removed when false positives are fixed. If that's the case, I think it's worth outlining this in rule docs.

@Belco90
Copy link
Member

Belco90 commented Jun 6, 2022

Thanks for adding this clarification!

@Belco90 Belco90 merged commit 63e3f13 into testing-library:main Jun 6, 2022
@github-actions
Copy link

🎉 This PR is included in version 5.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants