Skip to content

Use disjunction to separate allowed render result names #529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

diegocasmo
Copy link
Contributor

@diegocasmo diegocasmo commented Jan 6, 2022

Checks

  • I have read the contributing guidelines.
  • If some rule is added/updated/removed, I've regenerated the rules list.
  • If some rule meta info is changed, I've regenerated the plugin shared configs.

Changes

  • Use disjunction to separate allowed render result names

Context

Separate allowed render result names by comma and an "or" before the last one.

Before:

`wrapper` is not a recommended name for `render` returned value. Instead, you should destructure it, or name it using one of: `view`, `utils`

After:

`wrapper` is not a recommended name for `render` returned value. Instead, you should destructure it, or name it using one of: `view`, or `utils`

@Belco90 Belco90 self-assigned this Jan 6, 2022
@Belco90
Copy link
Member

Belco90 commented Jan 9, 2022

Hey @diegocasmo! Thanks for your contribution, looks good to me.

@Belco90 Belco90 merged commit 3729454 into testing-library:main Jan 9, 2022
@Belco90
Copy link
Member

Belco90 commented Jan 9, 2022

@all-contributors please add @diegocasmo for code

@allcontributors
Copy link
Contributor

@Belco90

I've put up a pull request to add @diegocasmo! 🎉

@github-actions
Copy link

github-actions bot commented Jan 9, 2022

🎉 This PR is included in version 5.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants