feat(prefer-find-by): report presence assertions

[zaicevas]

Checks

• I have read the contributing guidelines.
• If some rule is added/updated/removed, I've regenerated the rules list.
• If some rule meta info is changed, I've regenerated the plugin shared configs.

Changes

• Enhances prefer-find-by by reporting presence assertions

Context

Closes #420
Not gonna lie, took much more effort and AST parsing than I initially thought 😄

[Belco90]

@zaicevas oh wow, it seems complex indeed!

I'll try to take a look at the end of the week, thanks ✨

[Belco90]

It looks great in general! I just requested an additional test.

The implementation to detect the waitFor + presence/absence assertion seems a bit brittle since it's too tight to a particular tree. But I guess this is what it is, right?

I'm surprised the auto-fix works for this new invalid usage reported 😮

[zaicevas]

The implementation to detect the waitFor + presence/absence assertion seems a bit brittle since it's too tight to a particular tree. But I guess this is what it is, right?

Yeah :S I guess one can't escape that.

I'm surprised the auto-fix works for this new invalid usage reported 😮

Yep, that's because it relies on a few variables (such as queryMethod, queryVariant) so it was enough to fill these properly.

---

I've noticed github actions are failing because of what seems to be unrelated reasons. Would you mind helping with that?

[Belco90]

All good from my side. Thanks again!

[github-actions]

🎉 This PR is included in version 4.12.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀