fix(no-unnecessary-act): report everything that's reported in non-strict

[zaicevas]

Closes #416

Everything that is reported with isStrict disabled should also be reported with isStrict enabled. That's what this PR fixes.

With regards to tests - went with the quickest approach. Shamelessly copy-pasted test cases and enabled isStrict 😄 If we have a better way to deal with this duplication - let me know.

[Belco90]

I'm happy duplicating those tests to enable isStrict mode.

[MichaelDeBoey]

What about instead of duplicating them, we create a helper function that takes rules and add the strict: true option, like I did in consistent-data-testid?
This way, we don't have to duplicate all the testcases.

eslint-plugin-testing-library/tests/lib/rules/consistent-data-testid.test.ts

Lines 12 to 23 in 4bf6d76

	type ValidTestCase = TSESLint.ValidTestCase<Options>;
	type InvalidTestCase = TSESLint.InvalidTestCase<MessageIds, Options>;
	type TestCase = InvalidTestCase | ValidTestCase;
	const disableAggressiveReporting = <T extends TestCase>(array: T[]): T[] =>
	array.map((testCase) => ({
	...testCase,
	settings: {
	'testing-library/utils-module': 'off',
	'testing-library/custom-renders': 'off',
	'testing-library/custom-queries': 'off',
	},
	}));

eslint-plugin-testing-library/tests/lib/rules/consistent-data-testid.test.ts

Lines 357 to 363 in 4bf6d76

	ruleTester.run(RULE_NAME, rule, {
	valid: [...validTestCases, ...disableAggressiveReporting(validTestCases)],
	invalid: [
	...invalidTestCases,
	...disableAggressiveReporting(invalidTestCases),
	],
	});

[github-actions]

🎉 This PR is included in version 4.10.1 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀