Skip to content

feat(prefer-explicit-assert): report on findBy* queries too #421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 20, 2021

Conversation

zaicevas
Copy link
Contributor

Part of #409

Reports standalone findBy* queries. Reporting wrong assertions is out of scope for this PR.

@MichaelDeBoey MichaelDeBoey changed the title feat: extend prefer-explicit-assert to include findBy* queries feat(prefer-explicit-assert): report on findBy* queries too Jul 20, 2021
Copy link
Member

@Belco90 Belco90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to go 🚀

Thanks for your work on the recent PRs!

@Belco90 Belco90 linked an issue Jul 20, 2021 that may be closed by this pull request
@Belco90 Belco90 enabled auto-merge (squash) July 20, 2021 11:21
@Belco90 Belco90 merged commit c92e7ff into testing-library:main Jul 20, 2021
@github-actions
Copy link

🎉 This PR is included in version 4.10.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend prefer-explicit-assert to report findBy* and waitFor
2 participants