Skip to content

chore: add tests for Node 16 #350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 18, 2021
Merged

chore: add tests for Node 16 #350

merged 1 commit into from
May 18, 2021

Conversation

MichaelDeBoey
Copy link
Member

@MichaelDeBoey MichaelDeBoey commented Apr 21, 2021 •
edited
Loading

Belco90
Belco90 requested changes Apr 21, 2021
View reviewed changes
Copy link
Member

@Belco90 Belco90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm afraid this will suffer the same issue with node v15, since it uses npm v7 which installs peer dependencies and leads to some errors. This has to be investigated and fixed before being able to merge it.

@Belco90 Belco90 added chore Changes that affect the build system, CI config or other changes that don't modify src/test files dependencies Pull requests that update a dependency file labels Apr 21, 2021
@Belco90 Belco90 mentioned this pull request May 14, 2021
Closed
4 tasks
@Belco90
Copy link
Member

Belco90 commented May 18, 2021

Hey @MichaelDeBoey! Could you update this branch with main to check if the peer dependencies issue has been solved, please?

@MichaelDeBoey MichaelDeBoey requested a review from Belco90 May 18, 2021 16:47
@MichaelDeBoey MichaelDeBoey enabled auto-merge (squash) May 18, 2021 16:55
@Belco90 Belco90 disabled auto-merge May 18, 2021 17:36
@Belco90 Belco90 merged commit ef03394 into testing-library:main May 18, 2021
@github-actions
Copy link

🎉 This PR is included in version 4.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@MichaelDeBoey MichaelDeBoey deleted the patch-1 branch May 18, 2021 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Belco90 Belco90 Belco90 approved these changes

Assignees
No one assigned
Labels
chore Changes that affect the build system, CI config or other changes that don't modify src/test files dependencies Pull requests that update a dependency file released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MichaelDeBoey @Belco90