Skip to content

Move rules settings to ESLint shared config: part 5 - refactor consistent-data-testid rule #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Nov 3, 2020
Merged

Move rules settings to ESLint shared config: part 5 - refactor consistent-data-testid rule #248

Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
0fec322
feat: new setting for customizing file name pattern to report
Belco90 Oct 26, 2020
4ec2a68
test: add custom rule tester for testing library
Belco90 Oct 27, 2020
6f92a90
refactor: use common rule tester config
Belco90 Oct 28, 2020
bbe10df
refactor(no-dom-import): use createTestingLibraryRule
Belco90 Oct 28, 2020
6a10b4d
feat(detection-helpers): check imports with require
Belco90 Oct 31, 2020
370e133
test(no-dom-import): include test cases for custom module setting
Belco90 Nov 1, 2020
a5cf7ec
test(no-dom-import): include test cases for custom module setting
Belco90 Nov 1, 2020
2414b6d
chore: fix merge
Belco90 Nov 1, 2020
0e4f3dd
chore: fix merge
Belco90 Nov 1, 2020
93bbbb7
refactor(no-dom-import): extract detection helpers for import nodes
Belco90 Nov 1, 2020
20f2c6a
test: increase coverage
Belco90 Nov 1, 2020
12569d6
refactor: rename setting for filename pattern
Belco90 Nov 1, 2020
ba1a5b4
Merge remote-tracking branch 'origin/v4' into issue/198__no-dom-import
Belco90 Nov 1, 2020
f1afc6f
refactor: add new detection option to skip reporting checks
Belco90 Nov 1, 2020
a002ba9
refactor(consistent-data-testid): use createTestingLibraryRule
Belco90 Nov 1, 2020
8a6811e
Merge remote-tracking branch 'origin/v4' into issue/198__consistent-d…
Belco90 Nov 1, 2020
15eb73b
revert: refactor consistent-data-testid
Belco90 Nov 2, 2020
b7aa7ca
revert: detection options
Belco90 Nov 2, 2020
bbb3dfa
docs(consistent-data-testid): add clarification about rule creation
Belco90 Nov 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions lib/rules/consistent-data-testid.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { getDocsUrl } from '../utils';
import { ESLintUtils, TSESTree } from '@typescript-eslint/experimental-utils';
import { ESLintUtils } from '@typescript-eslint/experimental-utils';
import { isJSXAttribute, isLiteral } from '../node-utils';

export const RULE_NAME = 'consistent-data-testid';
Expand All @@ -13,6 +13,11 @@ type Options = [

const FILENAME_PLACEHOLDER = '{fileName}';

/**
* This rule is not created with `createTestingLibraryRule` since:
* - it doesn't need any detection helper
* - it doesn't apply to testing files but component files
*/
export default ESLintUtils.RuleCreator(getDocsUrl)<Options, MessageIds>({
name: RULE_NAME,
meta: {
Expand Down Expand Up @@ -89,7 +94,7 @@ export default ESLintUtils.RuleCreator(getDocsUrl)<Options, MessageIds>({
}

return {
[`JSXIdentifier`]: (node: TSESTree.JSXIdentifier) => {
JSXIdentifier: (node) => {
if (
!isJSXAttribute(node.parent) ||
!isLiteral(node.parent.value) ||
Expand Down