chore: updating dev deps. check formatting on travis ci #215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gndelia
added
the
chore
|
This is ready to review |
gndelia
force-pushed
the
check-formatting-ci
branch
from
9d48cc8 to
2ff5f7b
Compare
|
closing in favor of applying these changes in a PR targeting v4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #210
I'll be doing some commits with
--no-verifyto force CI failure (to check it's working)I also updated 4 dev dependencies
(foo?.baz)which we use in TS files.I could update prettier to the latest but I thought it'd be better to do it in a separated PR as I think they changed some defaults and it may do the PR larger than it's required.
The breaking changes of these ☝️ is just dropping old node support, which is not required for linting our code