feat(no-render-in-setup): adds no-render-in-setup rule, closes #207

README.md

@@ -23,7 +23,9 @@
 [![Tweet][tweet-badge]][tweet-url]
 
 <!-- ALL-CONTRIBUTORS-BADGE:START - Do not remove or modify this section -->
+
 [![All Contributors](https://img.shields.io/badge/all_contributors-29-orange.svg?style=flat-square)](#contributors-)
+
 <!-- ALL-CONTRIBUTORS-BADGE:END -->
 
 ## Installation
@@ -141,6 +143,7 @@ To enable this configuration use the `extends` property in your
 | [no-debug](docs/rules/no-debug.md)                                     | Disallow the use of `debug`                                                | ![angular-badge][] ![react-badge][] ![vue-badge][]                        |                    |
 | [no-dom-import](docs/rules/no-dom-import.md)                           | Disallow importing from DOM Testing Library                                | ![angular-badge][] ![react-badge][] ![vue-badge][]                        | ![fixable-badge][] |
 | [no-manual-cleanup](docs/rules/no-manual-cleanup.md)                   | Disallow the use of `cleanup`                                              |                                                                           |                    |
+| [no-render-in-setup](docs/rules/no-render-in-setup.md)                 | Disallow the use of `render` in setup functions                            |                                                                           |                    |
 | [no-wait-for-empty-callback](docs/rules/no-wait-for-empty-callback.md) | Disallow empty callbacks for `waitFor` and `waitForElementToBeRemoved`     |                                                                           |                    |
 | [prefer-explicit-assert](docs/rules/prefer-explicit-assert.md)         | Suggest using explicit assertions rather than just `getBy*` queries        |                                                                           |                    |
 | [prefer-find-by](docs/rules/prefer-find-by.md)                         | Suggest using `findBy*` methods instead of the `waitFor` + `getBy` queries | ![recommended-badge][] ![angular-badge][] ![react-badge][] ![vue-badge][] | ![fixable-badge][] |
@@ -219,6 +222,7 @@ Thanks goes to these wonderful people ([emoji key](https://allcontributors.org/d
 
 <!-- markdownlint-enable -->
 <!-- prettier-ignore-end -->
+
 <!-- ALL-CONTRIBUTORS-LIST:END -->
 
 This project follows the [all-contributors](https://github.com/all-contributors/all-contributors) specification. Contributions of any kind welcome!

docs/rules/no-render-in-setup.md

@@ -0,0 +1,57 @@
+# Disallow the use of `render` in setup functions (no-render-in-setup)
+
+## Rule Details
+
+This rule disallows the usage of `render` (or a custom render function) in setup functions (`beforeEach` and `beforeAll`) in favor of moving `render` closer to test assertions.
+
+Examples of **incorrect** code for this rule:
+
+```js
+beforeEach(() => {
+  render(<MyComponent />);
+});
+
+it('Should have foo', () => {
+  expect(screen.getByText('foo')).toBeInTheDocument();
+});
+
+it('Should have bar', () => {
+  expect(screen.getByText('bar')).toBeInTheDocument();
+});
+```
+
+```js
+beforeAll(() => {
+  render(<MyComponent />);
+});
+
+it('Should have foo', () => {
+  expect(screen.getByText('foo')).toBeInTheDocument();
+});
+
+it('Should have bar', () => {
+  expect(screen.getByText('bar')).toBeInTheDocument();
+});
+```
+
+Examples of **correct** code for this rule:
+
+```js
+it('Should have foo and bar', () => {
+  render(<MyComponent />);
+  expect(screen.getByText('foo')).toBeInTheDocument();
+  expect(screen.getByText('bar')).toBeInTheDocument();
+});
+```
+
+If you use [custom render functions](https://testing-library.com/docs/example-react-redux) then you can set a config option in your `.eslintrc` to look for these.
+
+```
+   "testing-library/no-render-in-setup": ["error", {"renderFunctions": ["renderWithRedux", "renderWithRouter"]}],
+```
+
+If you would like to allow the use of `render` (or a custom render function) in _either_ `beforeAll` or `beforeEach`, this can be configured using the option `allowTestingFrameworkSetupHook`. This may be useful if you have configured your tests to [skip auto cleanup](https://testing-library.com/docs/react-testing-library/setup#skipping-auto-cleanup). `allowTestingFrameworkSetupHook` is an enum that accepts either `"beforeAll"` or `"beforeEach"`.
+
+```
+   "testing-library/no-render-in-setup": ["error", {"allowTestingFrameworkSetupHook": "beforeAll"}],
+```

lib/index.ts

@@ -6,6 +6,7 @@ import noAwaitSyncQuery from './rules/no-await-sync-query';
 import noDebug from './rules/no-debug';
 import noDomImport from './rules/no-dom-import';
 import noManualCleanup from './rules/no-manual-cleanup';
+import noRenderInSetup from './rules/no-render-in-setup';
 import noWaitForEmptyCallback from './rules/no-wait-for-empty-callback';
 import preferExplicitAssert from './rules/prefer-explicit-assert';
 import preferPresenceQueries from './rules/prefer-presence-queries';
@@ -22,6 +23,7 @@ const rules = {
   'no-debug': noDebug,
   'no-dom-import': noDomImport,
   'no-manual-cleanup': noManualCleanup,
+  'no-render-in-setup': noRenderInSetup,
   'no-wait-for-empty-callback': noWaitForEmptyCallback,
   'prefer-explicit-assert': preferExplicitAssert,
   'prefer-find-by': preferFindBy,

lib/node-utils.ts

@@ -50,6 +50,22 @@ export function isVariableDeclarator(
   return node && node.type === AST_NODE_TYPES.VariableDeclarator;
 }
 
+export function isRenderFunction(
+  callNode: TSESTree.CallExpression,
+  renderFunctions: string[]
+) {
+  // returns true for `render` and e.g. `customRenderFn`
+  // as well as `someLib.render` and `someUtils.customRenderFn`
+  return ['render', ...renderFunctions].some(name => {
+    return (
+      (isIdentifier(callNode.callee) && name === callNode.callee.name) ||
+      (isMemberExpression(callNode.callee) &&
+        isIdentifier(callNode.callee.property) &&
+        name === callNode.callee.property.name)
+    );
+  });
+}
+
 export function isObjectPattern(
   node: TSESTree.Node
 ): node is TSESTree.ObjectPattern {

lib/rules/no-debug.ts

@@ -9,19 +9,11 @@ import {
   isAwaitExpression,
   isMemberExpression,
   isImportSpecifier,
+  isRenderFunction,
 } from '../node-utils';
 
 export const RULE_NAME = 'no-debug';
 
-function isRenderFunction(
-  callNode: TSESTree.CallExpression,
-  renderFunctions: string[]
-) {
-  return ['render', ...renderFunctions].some(
-    name => isIdentifier(callNode.callee) && name === callNode.callee.name
-  );
-}
-
 function isRenderVariableDeclarator(
   node: TSESTree.VariableDeclarator,
   renderFunctions: string[]

lib/rules/no-manual-cleanup.ts

@@ -21,7 +21,7 @@ export default ESLintUtils.RuleCreator(getDocsUrl)<Options, MessageIds>({
   meta: {
     type: 'problem',
     docs: {
-      description: ' Disallow the use of `cleanup`',
+      description: 'Disallow the use of `cleanup`',
       category: 'Best Practices',
       recommended: false,
     },
@@ -121,7 +121,6 @@ export default ESLintUtils.RuleCreator(getDocsUrl)<Options, MessageIds>({
               messageId: 'noManualCleanup',
             });
           }
-
         } else {
           defaultRequireFromTestingLibrary = declaratorNode.id;
         }

lib/rules/no-render-in-setup.ts

@@ -0,0 +1,96 @@
+import { ESLintUtils, TSESTree } from '@typescript-eslint/experimental-utils';
+import { getDocsUrl, TESTING_FRAMEWORK_SETUP_HOOKS } from '../utils';
+import {
+  isIdentifier,
+  isCallExpression,
+  isRenderFunction,
+} from '../node-utils';
+
+export const RULE_NAME = 'no-render-in-setup';
+export type MessageIds = 'noRenderInSetup';
+
+export function findClosestBeforeHook(
+  node: TSESTree.Node,
+  testingFrameworkSetupHooksToFilter: string[]
+): TSESTree.Identifier | null {
+  if (node === null) return null;
+  if (
+    isCallExpression(node) &&
+    isIdentifier(node.callee) &&
+    testingFrameworkSetupHooksToFilter.includes(node.callee.name)
+  ) {
+    return node.callee;
+  }
+
+  return findClosestBeforeHook(node.parent, testingFrameworkSetupHooksToFilter);
+}
+
+export default ESLintUtils.RuleCreator(getDocsUrl)({
+  name: RULE_NAME,
+  meta: {
+    type: 'problem',
+    docs: {
+      description: 'Disallow the use of `render` in setup functions',
+      category: 'Best Practices',
+      recommended: false,
+    },
+    messages: {
+      noRenderInSetup:
+        'Move `render` out of `{{name}}` and into individual tests.',
+    },
+    fixable: null,
+    schema: [
+      {
+        type: 'object',
+        properties: {
+          renderFunctions: {
+            type: 'array',
+          },
+          allowTestingFrameworkSetupHook: {
+            enum: TESTING_FRAMEWORK_SETUP_HOOKS,
+          },
+        },
+        anyOf: [
+          {
+            required: ['renderFunctions'],
+          },
+          {
+            required: ['allowTestingFrameworkSetupHook'],
+          },
+        ],
+      },
+    ],
+  },
+  defaultOptions: [
+    {
+      renderFunctions: [],
+      allowTestingFrameworkSetupHook: '',
+    },
+  ],
+
+  create(context, [{ renderFunctions, allowTestingFrameworkSetupHook }]) {
+    return {
+      CallExpression(node) {
+        let testingFrameworkSetupHooksToFilter = TESTING_FRAMEWORK_SETUP_HOOKS;
+        if (allowTestingFrameworkSetupHook.length !== 0) {
+          testingFrameworkSetupHooksToFilter = TESTING_FRAMEWORK_SETUP_HOOKS.filter(
+            hook => hook !== allowTestingFrameworkSetupHook
+          );
+        }
+        const beforeHook = findClosestBeforeHook(
+          node,
+          testingFrameworkSetupHooksToFilter
+        );
+        if (isRenderFunction(node, renderFunctions) && beforeHook) {
+          context.report({
+            node,
+            messageId: 'noRenderInSetup',
+            data: {
+              name: beforeHook.name,
+            },
+          });
+        }
+      },
+    };
+  },
+});

lib/utils.ts

@@ -63,6 +63,8 @@ const ASYNC_UTILS = [
   'waitForDomChange',
 ];
 
+const TESTING_FRAMEWORK_SETUP_HOOKS = ['beforeEach', 'beforeAll'];
+
 export {
   getDocsUrl,
   SYNC_QUERIES_VARIANTS,
@@ -73,5 +75,6 @@ export {
   ASYNC_QUERIES_COMBINATIONS,
   ALL_QUERIES_COMBINATIONS,
   ASYNC_UTILS,
+  TESTING_FRAMEWORK_SETUP_HOOKS,
   LIBRARY_MODULES,
 };