docs(prefer-screen-queries): update allowed properties and methods #158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gndelia
force-pushed
the
docs/update-prefer-screen-queries-to-include-container
branch
from
f17275e to
96dd651
Compare
|
Nice one! #157 is merged so you can rebase it now. |
gndelia
force-pushed
the
docs/update-prefer-screen-queries-to-include-container
branch
from
96dd651 to
377f21d
Compare
Belco90
requested changes
Jun 11, 2020
| { | ||
| code: ` | ||
| const screen = render(baz); | ||
| screen.container.querySelector('foo'); |
gndelia
force-pushed
the
docs/update-prefer-screen-queries-to-include-container
branch
from
377f21d to
54dd53e
Compare
Belco90
approved these changes
Jun 11, 2020
Belco90
changed the title
|
🎉 This PR is included in version 3.2.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires rebasing after #157 is merged. The changes are in this commit f17275e
edit: The properties + methods I included come from the typings here https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/testing-library__react/index.d.ts#L19