fix: correct consistent-data-testid docs example #146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gndelia
approved these changes
May 28, 2020
|
Thanks guys! |
|
🎉 This PR is included in version 3.1.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
This should be a doc PR type rather than fix to avoid releasing a new package tho. Not a big deal anyway. |
|
@all-contributors please add @jmcriffey for doc |
|
I've put up a pull request to add @jmcriffey! 🎉 |
|
@all-contributors please add @gndelia for review |
|
I've put up a pull request to add @gndelia! 🎉 |
|
Ah got it @Belco90 , I'll try to remember it for next time + the contributors bot :) |
|
No problem. I guess I should add this to contributing guidelines or somewhere else? |
|
I don't have a strong opinion on this, but I guess it can't hurt to add it (or later if it happens too many times) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just noticed the docs don't have the correct rule name here as I was having some trouble getting it to work.