no-wait-for-side-effects: not reporting VariableDeclaration nodes

[Belco90]

Also, I've noticed this rule is NOT reporting this case. Is that intentional? 🤔

    await waitFor(() => {

      userEvent.click(button) // reported

      const a = userEvent.click(button) // NOT reported

    })

Good catch. It's not intentional, but I detected it when implementing no-unnecessary-act, so it will be addressed there. I'll make sure to include this case in the tests.

Originally posted by @Belco90 in #363 (comment)

This will be finally addressed separately, after #259 gets released.

[Belco90]

@zaicevas pinging you here!

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[sjarva]

I'm asking this again @Belco90: I see you have assigned this to yourself, but since you haven't made a PR yet, would you mind if I submit one? 🤗

[Belco90]

@sjarva By all means! I didn't realize it was assigned to me 😓

[sjarva]

Thanks! Could you go through all issues that you have self-assigned and unassign yourself if aren't going to make a PR in the near future. (I found at least a couple of bugs, but not sure about feature issues.)

[Belco90]

Good idea! I just reviewed the issues assigned to myself and unassigned them.

[github-actions]

🎉 This issue has been resolved in version 5.7.3 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[github-actions]

🎉 This issue has been resolved in version 6.0.0-alpha.14 🎉

The release is available on:

• npm package (@alpha dist-tag)
• GitHub release

Your semantic-release bot 📦🚀