Skip to content

no-debug does not detect screen.debug() if screen is not last import in list #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
stefcameron opened this issue Jun 17, 2020 · 6 comments · Fixed by #175
Closed

no-debug does not detect screen.debug() if screen is not last import in list #174

stefcameron opened this issue Jun 17, 2020 · 6 comments · Fixed by #175
Labels
bug Something isn't working released

Comments

@stefcameron
Copy link

Love that no-debug rule, however:

import { render, screen } from '@testing-library/react';
// OR just (but not very useful): import { screen } from '@testing-library/react';
...
screen.debug(); // IS detected as lint

where as

import { screen, render } from '@testing-library/react';
...
screen.debug(); // is NOT detected as lint -- and should be
@nickserv nickserv added the bug Something isn't working label Jun 18, 2020
timdeschryver added a commit that referenced this issue Jun 18, 2020
@Belco90
Copy link
Member

Belco90 commented Jun 18, 2020

Hey Stefan, thanks for creating the issue! Interesting one.

Belco90 pushed a commit that referenced this issue Jun 18, 2020
@Belco90
Copy link
Member

Belco90 commented Jun 18, 2020

🎉 This issue has been resolved in version 3.3.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@stefcameron
Copy link
Author

@Belco90 My pleasure! Thanks for the super quick fix! 😄

@Belco90
Copy link
Member

Belco90 commented Jun 18, 2020

Credits to @timdeschryver !

I forgot to include you in our contributors so @all-contributors please add @stefcameron for bug

@allcontributors
Copy link
Contributor

@Belco90

I've put up a pull request to add @stefcameron! 🎉

@stefcameron
Copy link
Author

Wow, thanks! I'm honored! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants