Skip to content

Commit 8fb3b64

Browse files
committed
feat(no-wait-for-multiple-assertions): add to all configs by default (#483)
BREAKING CHANGE: `no-wait-for-multiple-assertions` is now enabled by default in all configs
1 parent 887e489 commit 8fb3b64

File tree

7 files changed

+13
-5
lines changed

7 files changed

+13
-5
lines changed

README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -203,7 +203,7 @@ To enable this configuration use the `extends` property in your
203203
| [`testing-library/no-render-in-setup`](./docs/rules/no-render-in-setup.md) | Disallow the use of `render` in testing frameworks setup functions | | ![angular-badge][] ![react-badge][] ![vue-badge][] |
204204
| [`testing-library/no-unnecessary-act`](./docs/rules/no-unnecessary-act.md) | Disallow wrapping Testing Library utils or empty callbacks in `act` | | ![react-badge][] |
205205
| [`testing-library/no-wait-for-empty-callback`](./docs/rules/no-wait-for-empty-callback.md) | Disallow empty callbacks for `waitFor` and `waitForElementToBeRemoved` | | ![dom-badge][] ![angular-badge][] ![react-badge][] ![vue-badge][] |
206-
| [`testing-library/no-wait-for-multiple-assertions`](./docs/rules/no-wait-for-multiple-assertions.md) | Disallow the use of multiple `expect` calls inside `waitFor` | | |
206+
| [`testing-library/no-wait-for-multiple-assertions`](./docs/rules/no-wait-for-multiple-assertions.md) | Disallow the use of multiple `expect` calls inside `waitFor` | | ![dom-badge][] ![angular-badge][] ![react-badge][] ![vue-badge][] |
207207
| [`testing-library/no-wait-for-side-effects`](./docs/rules/no-wait-for-side-effects.md) | Disallow the use of side effects in `waitFor` | | |
208208
| [`testing-library/no-wait-for-snapshot`](./docs/rules/no-wait-for-snapshot.md) | Ensures no snapshot is generated inside of a `waitFor` call | | |
209209
| [`testing-library/prefer-explicit-assert`](./docs/rules/prefer-explicit-assert.md) | Suggest using explicit assertions rather than standalone queries | | |

lib/configs/angular.ts

+1
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ export = {
1515
'testing-library/no-promise-in-fire-event': 'error',
1616
'testing-library/no-render-in-setup': 'error',
1717
'testing-library/no-wait-for-empty-callback': 'error',
18+
'testing-library/no-wait-for-multiple-assertions': 'error',
1819
'testing-library/prefer-find-by': 'error',
1920
'testing-library/prefer-screen-queries': 'error',
2021
'testing-library/render-result-naming-convention': 'error',

lib/configs/dom.ts

+1
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ export = {
1010
'testing-library/no-await-sync-query': 'error',
1111
'testing-library/no-promise-in-fire-event': 'error',
1212
'testing-library/no-wait-for-empty-callback': 'error',
13+
'testing-library/no-wait-for-multiple-assertions': 'error',
1314
'testing-library/prefer-find-by': 'error',
1415
'testing-library/prefer-screen-queries': 'error',
1516
},

lib/configs/react.ts

+1
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ export = {
1616
'testing-library/no-render-in-setup': 'error',
1717
'testing-library/no-unnecessary-act': ['error', { isStrict: true }],
1818
'testing-library/no-wait-for-empty-callback': 'error',
19+
'testing-library/no-wait-for-multiple-assertions': 'error',
1920
'testing-library/prefer-find-by': 'error',
2021
'testing-library/prefer-screen-queries': 'error',
2122
'testing-library/render-result-naming-convention': 'error',

lib/configs/vue.ts

+1
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ export = {
1616
'testing-library/no-promise-in-fire-event': 'error',
1717
'testing-library/no-render-in-setup': 'error',
1818
'testing-library/no-wait-for-empty-callback': 'error',
19+
'testing-library/no-wait-for-multiple-assertions': 'error',
1920
'testing-library/prefer-find-by': 'error',
2021
'testing-library/prefer-screen-queries': 'error',
2122
'testing-library/render-result-naming-convention': 'error',

lib/rules/no-wait-for-multiple-assertions.ts

+4-4
Original file line numberDiff line numberDiff line change
@@ -19,10 +19,10 @@ export default createTestingLibraryRule<Options, MessageIds>({
1919
'Disallow the use of multiple `expect` calls inside `waitFor`',
2020
category: 'Best Practices',
2121
recommendedConfig: {
22-
dom: false,
23-
angular: false,
24-
react: false,
25-
vue: false,
22+
dom: 'error',
23+
angular: 'error',
24+
react: 'error',
25+
vue: 'error',
2626
},
2727
},
2828
messages: {

tests/__snapshots__/index.test.ts.snap

+4
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ Object {
2020
"testing-library/no-promise-in-fire-event": "error",
2121
"testing-library/no-render-in-setup": "error",
2222
"testing-library/no-wait-for-empty-callback": "error",
23+
"testing-library/no-wait-for-multiple-assertions": "error",
2324
"testing-library/prefer-find-by": "error",
2425
"testing-library/prefer-screen-queries": "error",
2526
"testing-library/render-result-naming-convention": "error",
@@ -35,6 +36,7 @@ Object {
3536
"testing-library/no-await-sync-query": "error",
3637
"testing-library/no-promise-in-fire-event": "error",
3738
"testing-library/no-wait-for-empty-callback": "error",
39+
"testing-library/no-wait-for-multiple-assertions": "error",
3840
"testing-library/prefer-find-by": "error",
3941
"testing-library/prefer-screen-queries": "error",
4042
},
@@ -63,6 +65,7 @@ Object {
6365
},
6466
],
6567
"testing-library/no-wait-for-empty-callback": "error",
68+
"testing-library/no-wait-for-multiple-assertions": "error",
6669
"testing-library/prefer-find-by": "error",
6770
"testing-library/prefer-screen-queries": "error",
6871
"testing-library/render-result-naming-convention": "error",
@@ -87,6 +90,7 @@ Object {
8790
"testing-library/no-promise-in-fire-event": "error",
8891
"testing-library/no-render-in-setup": "error",
8992
"testing-library/no-wait-for-empty-callback": "error",
93+
"testing-library/no-wait-for-multiple-assertions": "error",
9094
"testing-library/prefer-find-by": "error",
9195
"testing-library/prefer-screen-queries": "error",
9296
"testing-library/render-result-naming-convention": "error",

0 commit comments

Comments
 (0)