Skip to content

Commit 887e489

Browse files
committed
feat(no-render-in-setup): add to Angular, React & Vue configs by default (#481)
BREAKING CHANGE: `no-render-in-setup` is now enabled by default in the Angular, React & Vue configs
1 parent 8c46203 commit 887e489

File tree

6 files changed

+10
-4
lines changed

6 files changed

+10
-4
lines changed

README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -200,7 +200,7 @@ To enable this configuration use the `extends` property in your
200200
| [`testing-library/no-manual-cleanup`](./docs/rules/no-manual-cleanup.md) | Disallow the use of `cleanup` | | |
201201
| [`testing-library/no-node-access`](./docs/rules/no-node-access.md) | Disallow direct Node access | | ![angular-badge][] ![react-badge][] ![vue-badge][] |
202202
| [`testing-library/no-promise-in-fire-event`](./docs/rules/no-promise-in-fire-event.md) | Disallow the use of promises passed to a `fireEvent` method | | ![dom-badge][] ![angular-badge][] ![react-badge][] ![vue-badge][] |
203-
| [`testing-library/no-render-in-setup`](./docs/rules/no-render-in-setup.md) | Disallow the use of `render` in testing frameworks setup functions | | |
203+
| [`testing-library/no-render-in-setup`](./docs/rules/no-render-in-setup.md) | Disallow the use of `render` in testing frameworks setup functions | | ![angular-badge][] ![react-badge][] ![vue-badge][] |
204204
| [`testing-library/no-unnecessary-act`](./docs/rules/no-unnecessary-act.md) | Disallow wrapping Testing Library utils or empty callbacks in `act` | | ![react-badge][] |
205205
| [`testing-library/no-wait-for-empty-callback`](./docs/rules/no-wait-for-empty-callback.md) | Disallow empty callbacks for `waitFor` and `waitForElementToBeRemoved` | | ![dom-badge][] ![angular-badge][] ![react-badge][] ![vue-badge][] |
206206
| [`testing-library/no-wait-for-multiple-assertions`](./docs/rules/no-wait-for-multiple-assertions.md) | Disallow the use of multiple `expect` calls inside `waitFor` | | |

lib/configs/angular.ts

+1
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ export = {
1313
'testing-library/no-dom-import': ['error', 'angular'],
1414
'testing-library/no-node-access': 'error',
1515
'testing-library/no-promise-in-fire-event': 'error',
16+
'testing-library/no-render-in-setup': 'error',
1617
'testing-library/no-wait-for-empty-callback': 'error',
1718
'testing-library/prefer-find-by': 'error',
1819
'testing-library/prefer-screen-queries': 'error',

lib/configs/react.ts

+1
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ export = {
1313
'testing-library/no-dom-import': ['error', 'react'],
1414
'testing-library/no-node-access': 'error',
1515
'testing-library/no-promise-in-fire-event': 'error',
16+
'testing-library/no-render-in-setup': 'error',
1617
'testing-library/no-unnecessary-act': ['error', { isStrict: true }],
1718
'testing-library/no-wait-for-empty-callback': 'error',
1819
'testing-library/prefer-find-by': 'error',

lib/configs/vue.ts

+1
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ export = {
1414
'testing-library/no-dom-import': ['error', 'vue'],
1515
'testing-library/no-node-access': 'error',
1616
'testing-library/no-promise-in-fire-event': 'error',
17+
'testing-library/no-render-in-setup': 'error',
1718
'testing-library/no-wait-for-empty-callback': 'error',
1819
'testing-library/prefer-find-by': 'error',
1920
'testing-library/prefer-screen-queries': 'error',

lib/rules/no-render-in-setup.ts

+3-3
Original file line numberDiff line numberDiff line change
@@ -53,9 +53,9 @@ export default createTestingLibraryRule<Options, MessageIds>({
5353
category: 'Best Practices',
5454
recommendedConfig: {
5555
dom: false,
56-
angular: false,
57-
react: false,
58-
vue: false,
56+
angular: 'error',
57+
react: 'error',
58+
vue: 'error',
5959
},
6060
},
6161
messages: {

tests/__snapshots__/index.test.ts.snap

+3
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ Object {
1818
],
1919
"testing-library/no-node-access": "error",
2020
"testing-library/no-promise-in-fire-event": "error",
21+
"testing-library/no-render-in-setup": "error",
2122
"testing-library/no-wait-for-empty-callback": "error",
2223
"testing-library/prefer-find-by": "error",
2324
"testing-library/prefer-screen-queries": "error",
@@ -54,6 +55,7 @@ Object {
5455
],
5556
"testing-library/no-node-access": "error",
5657
"testing-library/no-promise-in-fire-event": "error",
58+
"testing-library/no-render-in-setup": "error",
5759
"testing-library/no-unnecessary-act": Array [
5860
"error",
5961
Object {
@@ -83,6 +85,7 @@ Object {
8385
],
8486
"testing-library/no-node-access": "error",
8587
"testing-library/no-promise-in-fire-event": "error",
88+
"testing-library/no-render-in-setup": "error",
8689
"testing-library/no-wait-for-empty-callback": "error",
8790
"testing-library/prefer-find-by": "error",
8891
"testing-library/prefer-screen-queries": "error",

0 commit comments

Comments
 (0)