Merge remote-tracking branch 'origin/master' into v4

Author: Belco90

.all-contributorsrc

@@ -271,7 +271,8 @@
       "profile": "https://nickmccurdy.com/",
       "contributions": [
         "ideas",
-        "code"
+        "code",
+        "review"
       ]
     },
     {

README.md

@@ -209,7 +209,7 @@ Thanks goes to these wonderful people ([emoji key](https://allcontributors.org/d
     <td align="center"><a href="https://xxxl.digital/"><img src="https://avatars2.githubusercontent.com/u/42043025?v=4" width="100px;" alt=""/><br /><sub><b>Miguel Erja González</b></sub></a><br /><a href="https://github.com/testing-library/eslint-plugin-testing-library/issues?q=author%3Amiguelerja" title="Bug reports">🐛</a></td>
     <td align="center"><a href="http://pustovalov.dev"><img src="https://avatars2.githubusercontent.com/u/1568885?v=4" width="100px;" alt=""/><br /><sub><b>Pavel Pustovalov</b></sub></a><br /><a href="https://github.com/testing-library/eslint-plugin-testing-library/issues?q=author%3Apustovalov" title="Bug reports">🐛</a></td>
     <td align="center"><a href="https://github.com/jrparish"><img src="https://avatars3.githubusercontent.com/u/5173987?v=4" width="100px;" alt=""/><br /><sub><b>Jacob Parish</b></sub></a><br /><a href="https://github.com/testing-library/eslint-plugin-testing-library/issues?q=author%3Ajrparish" title="Bug reports">🐛</a> <a href="https://github.com/testing-library/eslint-plugin-testing-library/commits?author=jrparish" title="Code">💻</a> <a href="https://github.com/testing-library/eslint-plugin-testing-library/commits?author=jrparish" title="Tests">⚠️</a></td>
-    <td align="center"><a href="https://nickmccurdy.com/"><img src="https://avatars0.githubusercontent.com/u/927220?v=4" width="100px;" alt=""/><br /><sub><b>Nick McCurdy</b></sub></a><br /><a href="#ideas-nickmccurdy" title="Ideas, Planning, & Feedback">🤔</a> <a href="https://github.com/testing-library/eslint-plugin-testing-library/commits?author=nickmccurdy" title="Code">💻</a></td>
+    <td align="center"><a href="https://nickmccurdy.com/"><img src="https://avatars0.githubusercontent.com/u/927220?v=4" width="100px;" alt=""/><br /><sub><b>Nick McCurdy</b></sub></a><br /><a href="#ideas-nickmccurdy" title="Ideas, Planning, & Feedback">🤔</a> <a href="https://github.com/testing-library/eslint-plugin-testing-library/commits?author=nickmccurdy" title="Code">💻</a> <a href="https://github.com/testing-library/eslint-plugin-testing-library/pulls?q=is%3Apr+reviewed-by%3Anickmccurdy" title="Reviewed Pull Requests">👀</a></td>
     <td align="center"><a href="https://stefancameron.com/"><img src="https://avatars3.githubusercontent.com/u/2855350?v=4" width="100px;" alt=""/><br /><sub><b>Stefan Cameron</b></sub></a><br /><a href="https://github.com/testing-library/eslint-plugin-testing-library/issues?q=author%3Astefcameron" title="Bug reports">🐛</a></td>
   </tr>
 </table>

docs/rules/prefer-screen-queries.md

@@ -54,6 +54,12 @@ const utils = render(<Foo />);
 utils.rerender(<Foo />);
 utils.unmount();
 utils.asFragment();
+
+// the same functions, but called from destructuring
+const { rerender, unmount, asFragment } = render(<Foo />);
+rerender(<Foo />);
+asFragment();
+unmount();
 ```
 
 ## Further Reading

tests/lib/rules/prefer-screen-queries.test.ts

@@ -47,21 +47,39 @@ ruleTester.run(RULE_NAME, rule, {
     },
     {
       code: `
-        const utils = render(baz);
-        screen.rerender();
+        const { rerender } = render(baz);
+        rerender();
       `
     },
     {
       code: `
         const utils = render(baz);
-        utils.unmount();
+        utils.rerender();
       `
     },
     {
       code: `
         const utils = render(baz);
         utils.asFragment();
       `
+    },
+    {
+      code: `
+        const { asFragment } = render(baz);
+        asFragment();
+      `
+    },
+    {
+      code: `
+        const { unmount } = render(baz);
+        unmount();
+      `
+    },
+    {
+      code: `
+        const utils = render(baz);
+        utils.unmount();
+      `
     }
   ],
 

tests/lib/rules/prefer-wait-for.test.ts

@@ -60,6 +60,18 @@ ruleTester.run(RULE_NAME, rule, {
       cy.wait();
       `,
     },
+    {
+      // https://github.com/testing-library/eslint-plugin-testing-library/issues/145
+      code: `
+        async function wait(): Promise<any> {
+          // doesn't matter
+        }
+        
+        function callsWait(): void {
+          await wait();
+        }
+      `,
+    },
   ],
 
   invalid: [