Merge remote-tracking branch 'origin/master' into v4

# Conflicts:
#	README.md

Author: Belco90

.all-contributorsrc

@@ -263,6 +263,25 @@
         "code",
         "test"
       ]
+    },
+    {
+      "login": "nickmccurdy",
+      "name": "Nick McCurdy",
+      "avatar_url": "https://avatars0.githubusercontent.com/u/927220?v=4",
+      "profile": "https://nickmccurdy.com/",
+      "contributions": [
+        "ideas",
+        "code"
+      ]
+    },
+    {
+      "login": "stefcameron",
+      "name": "Stefan Cameron",
+      "avatar_url": "https://avatars3.githubusercontent.com/u/2855350?v=4",
+      "profile": "https://stefancameron.com/",
+      "contributions": [
+        "bug"
+      ]
     }
   ],
   "contributorsPerLine": 7,

README.md

@@ -24,7 +24,7 @@
 
 <!-- ALL-CONTRIBUTORS-BADGE:START - Do not remove or modify this section -->
 
-[![All Contributors](https://img.shields.io/badge/all_contributors-24-orange.svg?style=flat-square)](#contributors-)
+[![All Contributors](https://img.shields.io/badge/all_contributors-26-orange.svg?style=flat-square)](#contributors-)
 
 <!-- ALL-CONTRIBUTORS-BADGE:END -->
 
@@ -209,6 +209,8 @@ Thanks goes to these wonderful people ([emoji key](https://allcontributors.org/d
     <td align="center"><a href="https://xxxl.digital/"><img src="https://avatars2.githubusercontent.com/u/42043025?v=4" width="100px;" alt=""/><br /><sub><b>Miguel Erja González</b></sub></a><br /><a href="https://github.com/testing-library/eslint-plugin-testing-library/issues?q=author%3Amiguelerja" title="Bug reports">🐛</a></td>
     <td align="center"><a href="http://pustovalov.dev"><img src="https://avatars2.githubusercontent.com/u/1568885?v=4" width="100px;" alt=""/><br /><sub><b>Pavel Pustovalov</b></sub></a><br /><a href="https://github.com/testing-library/eslint-plugin-testing-library/issues?q=author%3Apustovalov" title="Bug reports">🐛</a></td>
     <td align="center"><a href="https://github.com/jrparish"><img src="https://avatars3.githubusercontent.com/u/5173987?v=4" width="100px;" alt=""/><br /><sub><b>Jacob Parish</b></sub></a><br /><a href="https://github.com/testing-library/eslint-plugin-testing-library/issues?q=author%3Ajrparish" title="Bug reports">🐛</a> <a href="https://github.com/testing-library/eslint-plugin-testing-library/commits?author=jrparish" title="Code">💻</a> <a href="https://github.com/testing-library/eslint-plugin-testing-library/commits?author=jrparish" title="Tests">⚠️</a></td>
+    <td align="center"><a href="https://nickmccurdy.com/"><img src="https://avatars0.githubusercontent.com/u/927220?v=4" width="100px;" alt=""/><br /><sub><b>Nick McCurdy</b></sub></a><br /><a href="#ideas-nickmccurdy" title="Ideas, Planning, & Feedback">🤔</a> <a href="https://github.com/testing-library/eslint-plugin-testing-library/commits?author=nickmccurdy" title="Code">💻</a></td>
+    <td align="center"><a href="https://stefancameron.com/"><img src="https://avatars3.githubusercontent.com/u/2855350?v=4" width="100px;" alt=""/><br /><sub><b>Stefan Cameron</b></sub></a><br /><a href="https://github.com/testing-library/eslint-plugin-testing-library/issues?q=author%3Astefcameron" title="Bug reports">🐛</a></td>
   </tr>
 </table>
 

lib/rules/no-debug.ts

@@ -8,6 +8,7 @@ import {
   isLiteral,
   isAwaitExpression,
   isMemberExpression,
+  isImportSpecifier,
 } from '../node-utils';
 
 export const RULE_NAME = 'no-debug';
@@ -141,12 +142,11 @@ export default ESLintUtils.RuleCreator(getDocsUrl)({
       },
       // checks if import has shape:
       // import { screen } from '@testing-library/dom';
-      'ImportDeclaration ImportSpecifier'(node: TSESTree.ImportSpecifier) {
-        const importDeclarationNode = node.parent as TSESTree.ImportDeclaration;
-
-        if (!hasTestingLibraryImportModule(importDeclarationNode)) return;
-
-        hasImportedScreen = node.imported.name === 'screen';
+      ImportDeclaration(node: TSESTree.ImportDeclaration) {
+        if (!hasTestingLibraryImportModule(node)) return;
+        hasImportedScreen = node.specifiers.some(
+          s => isImportSpecifier(s) && s.imported.name === 'screen'
+        );
       },
       // checks if import has shape:
       // import * as dtl from '@testing-library/dom';

tests/lib/rules/no-debug.test.ts

@@ -202,6 +202,18 @@ ruleTester.run(RULE_NAME, rule, {
         },
       ],
     },
+    {
+      // https://github.com/testing-library/eslint-plugin-testing-library/issues/174
+      code: `
+        import { screen, render } from '@testing-library/dom'
+        screen.debug()
+      `,
+      errors: [
+        {
+          messageId: 'noDebug',
+        },
+      ],
+    },
     {
       code: `
         import * as dtl from '@testing-library/dom';